Re: [RFC PATCH v6 1/3] selftests/x86: sysret_rip: Handle syscall in a FRED system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "H. Peter Anvin" <hpa@xxxxxxxxx>, Xin Li <xin3.li@xxxxxxxxx>
Subject: Re: [RFC PATCH v6 1/3] selftests/x86: sysret_rip: Handle syscall in a FRED system
From: Ammar Faizi <ammarfaizi2@xxxxxxxxxxx>
Date: Thu, 26 Jan 2023 06:01:54 +0700
Cc: Dave Hansen <dave.hansen@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "Kirill A. Shutemov" <kirill.shutemov@xxxxxxxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Brian Gerst <brgerst@xxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Andy Lutomirski <luto@xxxxxxxxxx>, x86 Mailing List <x86@xxxxxxxxxx>, Linux Kselftest Mailing List <linux-kselftest@xxxxxxxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20230125211714.838216-2-ammarfaizi2@gnuweeb.org>

On Thu, Jan 26, 2023 at 04:17:12AM +0700, Ammar Faizi wrote:
> +/*
> + * REGS_SAVED  = %rcx and %r11 preserved.
> + * REGS_SYSRET = %rcx and %r11 set to %rflags and %rip.
> + * REGS_ERROR  = %rcx and/or %r11 set to any other values.

Since we moved the assertion into check_regs_result(), we no longer
need REGS_ERROR. check_regs_result() is now a void function.

Will remove that comment...

-- 
Ammar Faizi

References:
- [RFC PATCH v2 0/2] selftests/x86: sysret_rip update for FRED system
  - From: Ammar Faizi
- [RFC PATCH v2 2/2] selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx` and `%r11`
  - From: Ammar Faizi
- Re: [RFC PATCH v2 2/2] selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx` and `%r11`
  - From: H. Peter Anvin
- Re: [RFC PATCH v2 2/2] selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx` and `%r11`
  - From: Ammar Faizi
- Re: [RFC PATCH v2 2/2] selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx` and `%r11`
  - From: H. Peter Anvin
- Re: [RFC PATCH v2 2/2] selftests/x86: sysret_rip: Add more syscall tests with respect to `%rcx` and `%r11`
  - From: Ammar Faizi
- [RFC PATCH v6 0/3] sysret_rip update for the Intel FRED architecture
  - From: Ammar Faizi
- [RFC PATCH v6 1/3] selftests/x86: sysret_rip: Handle syscall in a FRED system
  - From: Ammar Faizi

Prev by Date: [PATCH v3] lib/hashtable_test.c: add test for the hashtable structure
Next by Date: [PATCH] testing: kselftest_harness: add filtering and enumerating tests
Previous by thread: [RFC PATCH v6 1/3] selftests/x86: sysret_rip: Handle syscall in a FRED system
Next by thread: [RFC PATCH v6 3/3] selftests/x86: sysret_rip: Test opportunistic SYSRET
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]