On Fri, Jan 20, 2023 at 10:17 AM Huang Rui <ray.huang@xxxxxxx> wrote: > > On Fri, Jan 20, 2023 at 01:54:01PM +0800, Doug Smythies wrote: > > Revert the portion of a recent Makefile change that incorrectly > > deletes source files when doing "make clean". > > > > Fixes: ba2d788aa873 ("selftests: amd-pstate: Trigger tbench benchmark and test cpus") > > Reported-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> > > Tested-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> > > Signed-off-by: Doug Smythies <dsmythies@xxxxxxxxx> > > (+ Shuah and linux-kselftest mailing list) > > Thanks for fix! > > Acked-by: Huang Rui <ray.huang@xxxxxxx> > [ I already replied - but with these important CCs ] Hi Doug, Thanks for the patch! Small nit, I saw this with: $ make -C tools/ clean Otherwise: Reviewed-by: Sedat Dilek <sedat.dilek@xxxxxxxxx> BR, -Sedat- > > --- > > tools/testing/selftests/amd-pstate/Makefile | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/tools/testing/selftests/amd-pstate/Makefile b/tools/testing/selftests/amd-pstate/Makefile > > index 5f195ee756d6..5fd1424db37d 100644 > > --- a/tools/testing/selftests/amd-pstate/Makefile > > +++ b/tools/testing/selftests/amd-pstate/Makefile > > @@ -7,11 +7,6 @@ all: > > uname_M := $(shell uname -m 2>/dev/null || echo not) > > ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > > > > -ifeq (x86,$(ARCH)) > > -TEST_GEN_FILES += ../../../power/x86/amd_pstate_tracer/amd_pstate_trace.py > > -TEST_GEN_FILES += ../../../power/x86/intel_pstate_tracer/intel_pstate_tracer.py > > -endif > > - > > TEST_PROGS := run.sh > > TEST_FILES := basic.sh tbench.sh gitsource.sh > > > > -- > > 2.25.1 > > > >