On 02.01.23 17:16, Lorenzo Stoakes wrote:
On Mon, Jan 02, 2023 at 05:10:40PM +0100, David Hildenbrand wrote:
Maybe wait until tomorrow for feedback from others. Make sure to include my
acked-by.
Too late... I thought Andrew typically added these kind of things himself? As an
Acked-by could be a reply to an unmodified patch for example. Though I guess
it'd save you having to reply to the v4? Anyway sorry, already sent it!
Maintainers usually apply tags that are sent to the latest version, when
picking up the patch. Maintainers usually refrain from going through
multiple earlier patch versions to pick up tags -- especially, because
some changes might require a submitter from dropping tags (e.g., bigger
changes) and the tags might no longer be valid.
So better always include tags when resending, so they don't get lost.
It's sat in the mailing list so others can review further if required, this is a
bank holiday in the UK, and as a part-time contributor (and otherwise distracted
by book work) it is a rare moment to be able to respond to feedback so will tend
to get squashed into evenings/weekends/public holidays :) If people have further
comments I will, of course, respond as + when I can!
Cheers!
Happy holidays then :)
--
Thanks,
David / dhildenb
