> -----Original Message----- > From: Shunsuke Mie [mailto:mie@xxxxxxxxxx] > Sent: 21 December 2022 14:00 > To: Aman Gupta <aman1.gupta@xxxxxxxxxxx>; shradha.t@xxxxxxxxxxx; > pankaj.dubey@xxxxxxxxxxx; kishon@xxxxxx; lpieralisi@xxxxxxxxxx; > kw@xxxxxxxxx; shuah@xxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; > Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx> > Subject: Re: [PATCH] selftests: pci: pci-selftest: add support for PCI endpoint > driver test > > Hi Aman, > > It is a nice work. > > On 2022/10/07 14:39, Aman Gupta wrote: > > This patch enables the support to perform selftest on PCIe endpoint > > driver present in the system. The following tests are currently > > performed by the selftest utility > > > > 1. BAR Tests (BAR0 to BAR5) > > 2. MSI Interrupt Tests (MSI1 to MSI32) 3. Read Tests (For 1, 1024, > > 1025, 1024000, 1024001 Bytes) 4. Write Tests (For 1, 1024, 1025, > > 1024000, 1024001 Bytes) 5. Copy Tests (For 1, 1024, 1025, 1024000, > > 1024001 Bytes) > > > > Signed-off-by: Aman Gupta <aman1.gupta@xxxxxxxxxxx> > > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@xxxxxxxxxxx> > > --- > > tools/testing/selftests/Makefile | 1 + > > tools/testing/selftests/pci/.gitignore | 1 + > > tools/testing/selftests/pci/Makefile | 7 + > > tools/testing/selftests/pci/pci-selftest.c | 167 > > +++++++++++++++++++++ > This test is for a pci endpoint test driver. so I think it should be located on > tools/testing/selftest/drivers/pci/endpoint. What do you think? Hi Shunsuke, Thanks for the review and nice thought about relocating the file. As per the review provided by Manivanan, I will be changing the name of the file to endpoint-test.c and hence I am thinking to move this file to tools/testing/selftest/driver/pci/endpoint_test.c Thanks, Aman Gupta
