On Thu, Dec 08, 2022 at 10:33:19AM -0800, Jeff Xu wrote: > On Thu, Dec 8, 2022 at 8:13 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > On Wed, Dec 07, 2022 at 03:49:33PM +0000, jeffxu@xxxxxxxxxxxx wrote: > > > This is V6 version of patch: see [4] [5] [6] [7] for previous versions. > > > > When sending a new version, can you include an overview of what changed > > between this version and the prior version? This helps reviewers who are > > following along, so it's easier to focus our attention on the > > differences. Also, it's helpful to version the links: > > > > > [4] https://lwn.net/Articles/890096/ > > > [5] https://lore.kernel.org/lkml/20220805222126.142525-1-jeffxu@xxxxxxxxxx/ > > > [6] https://lore.kernel.org/lkml/20221202013404.163143-1-jeffxu@xxxxxxxxxx/ > > > [7] https://lore.kernel.org/lkml/20221206152358.1966099-1-jeffxu@xxxxxxxxxx/ > > > > e.g.: > > > > v6: > > - moved foo to bar > > - improve comments for baz > > v5: https://lore.kernel.org/lkml/20221206152358.1966099-1-jeffxu@xxxxxxxxxx/ > > v3: https://lore.kernel.org/lkml/20221202013404.163143-1-jeffxu@xxxxxxxxxx/ > > v2: ...etc > > > Will do! > Much appreciated for helping me through the process of my first patch > in the kernel. Happy to help! I'm excited to see this gap in memfd security closed. :) -- Kees Cook