Re: [PATCH v1 0/6] kselftest/alsa: pcm-test improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30. 11. 22 1:06, Mark Brown wrote:
This series provides a bunch of quick updates which should make the
coverage from pcm-test a bit more useful, it adds some support for
skipping tests when the hardware/driver is unable to support the
requested configuration and then expands the set of cases we cover to
include more sample rates and channel counts.  This should exercise
switching between 8kHz and 44.1kHz based rates and ensure that clocking
doesn't get confused by non-stereo channel counts, both of which are I
expect common real world errors, at least for embedded cards.

The current code allows to override "test.time1 {} test.time2 {}" blocks in the configuration files which is equivalent to "test { time1 {} time2 {} }". This changeset will introduce configuration lookups like "pcm.0.0.PLAYBACK.44k1.2.big {}" which creates another configuration structure. The '.' (compound level delimiter) should not be used in the test name.

My original idea for the next improvement was to parse the "pcm.0.0.PLAYBACK.test" compound and gather the tests for the given pcm. If this compound is missing, we can continue with the hard-coded defaults.

About the skips - the test should probably keep to support also the exact parameters. For example - if the hardware must support 6 channels, it should not be a skip but an error. Everything may be broken, including the PCM configuration refining.

I just sent the patch with my changes for comments [1]. It's just the base code which may be extended with your requirements. The skips may be implemented using configuration field like 'skip_if_rate_error yes' or so. Let me know, if I can stack your changes on top, or perhaps, you may be willing to adapt them.

					Jaroslav

[1] https://lore.kernel.org/alsa-devel/20221201173333.2494019-1-perex@xxxxxxxx/

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux