On 11/22/2022 11:43 PM, Shuah Khan wrote:
On 11/18/22 02:28, Tiezhu Yang wrote:
The latest version of grep claims the egrep is now obsolete so the build
now contains warnings that look like:
egrep: warning: egrep is obsolescent; using grep -E
fix this up by moving the related file to use "grep -E" instead.
sed -i "s/egrep/grep -E/g" `grep egrep -rwl tools/testing/selftests`
Here are the steps to install the latest grep:
wget http://ftp.gnu.org/gnu/grep/grep-3.8.tar.gz
tar xf grep-3.8.tar.gz
cd grep-3.8 && ./configure && make
sudo make install
export PATH=/usr/local/bin:$PATH
Does this change work without the latest grep? It seems to work on
grep (GNU grep) 3.7 when I ran quick test on kselftest_deps.sh with
your change.
Yes, AFAIK, "grep -E" is supported by various versions of grep.
We can see the following NEWS in grep-3.8 release announcement [1]:
"The egrep and fgrep commands, which have been deprecated since
release 2.5.3 (2007), now warn that they are obsolescent and should
be replaced by grep -E and grep -F."
[1] https://savannah.gnu.org/forum/forum.php?forum_id=10227
Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
---
.../selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc | 8
++++----
tools/testing/selftests/gpio/gpio-sim.sh | 2 +-
tools/testing/selftests/kselftest_deps.sh | 2 +-
tools/testing/selftests/net/toeplitz.sh | 2 +-
tools/testing/selftests/powerpc/scripts/hmi.sh | 2 +-
tools/testing/selftests/rcutorture/bin/console-badness.sh | 2 +-
tools/testing/selftests/rcutorture/bin/kvm-build.sh | 4
++--
tools/testing/selftests/rcutorture/bin/kvm-find-errors.sh | 4
++--
tools/testing/selftests/rcutorture/bin/kvm.sh | 4
++--
tools/testing/selftests/rcutorture/bin/parse-console.sh | 10
+++++-----
10 files changed, 20 insertions(+), 20 deletions(-)
Please split these into sepratate 5 patches. All rcu changes in one, net in
one, powerpc etc.
OK, maybe 6 patches,
(1) rcutorture
(2) ftrace
(3) powerpc
(4) gpio
(5) net
(6) kselftest_deps.sh
The change looks good to me.
Thank you, I will send v2 later.
Thanks,
Tiezhu
