Jason Gunthorpe <jgg@xxxxxxxxxx> writes: > On Thu, Nov 10, 2022 at 08:10:19AM -0700, Jonathan Corbet wrote: >> Jason Gunthorpe <jgg@xxxxxxxxxx> writes: >> >> > On Thu, Nov 10, 2022 at 07:49:14AM -0700, Jonathan Corbet wrote: >> > >> >> The *real* problem, methinks, is that the directives are added in patch 4 >> >> of the series, but the documentation doesn't show up until later. So >> >> the real fix would be to simply move this patch down. Or just not worry >> >> about it, since it all works out in the end and nobody will be bisecting >> >> a docs build. >> > >> > That is half the problem, the other is this: >> > >> > https://lore.kernel.org/r/0-v1-c80e152ce63b+12-kdoc_export_ns_jgg@xxxxxxxxxx >> > >> > Since even after the whole series the EXPORT_NS functions don't parse >> > properly. I'm going to put this patch before the doc patch and ignore >> > the bisection problem. >> > >> > I'd like someone to say they are happy with the perl :) >> >> I'm not happy with *any* perl! :) >> >> I've been sitting on that patch because I was under the impression >> another version was coming - was that wrong? > > I can resend it with the single regex if that is the preference - it > is not quite as exacting as the first version. I have to test it is > all. Single is nicer but it's not worth a great deal of angst; nothing we do is going to turn kernel-doc into a thing of beauty :) Thanks, jon
