Hi Shaopeng, On 11/1/2022 2:43 AM, Shaopeng Tan wrote: > There is a comment "Set up shemata with 100% allocation on the first run" > in function mbm_setup(), but there is an increment bug and the condition > "num_of_runs == 0" will never be met and write_schemata() will never be > called to set schemata to 100%. Even if write_schemata() is called in MBM > test, since it is not supported for MBM test it does not set the schemata. > This is currently fine because resctrl_val_parm->mum_resctrlfs is always 1 > and umount/mount will be run in each test to set the schemata to 100%. > > To support the usage when MBM test does not unmount/remount resctrl > filesystem before the test starts, fix to call write_schemata() and > set schemata properly when the function is called for the first time. > > Also, remove static local variable 'num_of_runs' because this is not > needed as there is resctrl_val_param->num_of_runs which should be used > instead like in cat_setup(). > > Signed-off-by: Shaopeng Tan <tan.shaopeng@xxxxxxxxxxxxxx> Thank you very much. Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> Reinette
