On Wed, Nov 2, 2022 at 11:38 PM David Gow <davidgow@xxxxxxxxxx> wrote: > > On Thu, Nov 3, 2022 at 12:40 AM 'Daniel Latypov' via KUnit Development > <kunit-dev@xxxxxxxxxxxxxxxx> wrote: > > > > Let's verify that the parser isn't reporting any errors for valid > > inputs. > > > > This change also > > * does result.status checking on one line > > * makes sure we consistently do it outside of the `with` block > > > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > > --- > > Looks good, thanks. > > Note that this patch does conflict with "kunit: tool: print summary of > failed tests if a few failed out of a lot": > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=f19dd011d8de6f0c1d20abea5158aa4f5d9cea44 > It's only a context line issue, though. > > Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Oh huh, I rebased onto the kunit branch and it managed to merge cleanly. I guess `git am` is more picky than `git rebase`. I'll send a v2 that's rebased to avoid issues applying them.
