Re: hmm_test issues with latest mainline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/14/22 05:21, Alistair Popple wrote:
> 
> Seems like this would fix both the SKIP in FIXTURE_SETUP and ASSERT in
> FIXTURE_TEARDOWN issues:

Yep, that fixed the infinite error loops for me, thanks.

...

>> Unlike hmm-tests though the above snippet reports correct pass/skip
>> statistics with the teardown assertion removed. This is because there is
>> also a bug in hmm-tests. Currently we have:
>>
>>    SKIP(exit(0), "DEVICE_COHERENT not available");
>>
>> Which should really be:
>>
>>    SKIP(return, "DEVICE_COHERENT not available");
>>

And with this on top, I got the skips due to DEVICE_COHERENT not available
counted correctly.

>> Of course that results in an infinite loop due to the associated
>> assertion failure during teardown which is still called despite the SKIP
>> in setup. Not sure if this is why it was originally coded this way.
>>
>>  - Alistair
>>
>>>> thanks,
>>>> -- Shuah
>>>>
>>>>
>>>>




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux