Hi Jamal: My apologise. I will be more careful before sending patch. Thanks to Victor and you for the review. Zhengchao Shao -----Original Message----- From: Jamal Hadi Salim [mailto:jhs@xxxxxxxxxxxx] Sent: Friday, September 30, 2022 6:25 PM To: Victor Nogueira <victor@xxxxxxxxxxxx> Cc: shaozhengchao <shaozhengchao@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; xiyou.wangcong@xxxxxxxxx; jiri@xxxxxxxxxxx; shuah@xxxxxxxxxx; weiyongjun (A) <weiyongjun1@xxxxxxxxxx>; yuehaibing <yuehaibing@xxxxxxxxxx> Subject: Re: [PATCH net-next,v2] selftests/tc-testing: update qdisc/cls/action features in config Please double check your work by testing it before submitting so we can save some cycles in reviewing. Those typos means your last commit was not tested. Acked-by: Jamal Hadi Salim <jhs@xxxxxxxxxxxx> cheers, jamal On Thu, Sep 29, 2022 at 8:22 PM Victor Nogueira <victor@xxxxxxxxxxxx> wrote: > > On Thu, Sep 29, 2022 at 1:11 AM Zhengchao Shao <shaozhengchao@xxxxxxxxxx> wrote: > > > > Since three patchsets "add tc-testing test cases", "refactor > > duplicate codes in the tc cls walk function", and "refactor > > duplicate codes in the qdisc class walk function" are merged to > > net-next tree, the list of supported features needs to be updated in config file. > > > > Signed-off-by: Zhengchao Shao <shaozhengchao@xxxxxxxxxx> > > Reviewed-by: Victor Nogueira <victor@xxxxxxxxxxxx>