Re: [PATCH -next v4 1/3] selftests/memory-hotplug: Add checking after online or offline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Reviewed-by: David Hildenbrand <david@xxxxxxxxxx>


I am questioning the stability of the offlining test, though.
Offlining a random memory block can fail easily, because "->removable" is not
expressive:

# tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
Test scope: 2% hotplug memory
           online all hot-pluggable memory in offline state:
                   SKIPPED - no hot-pluggable memory in offline state
           offline 2% hot-pluggable memory in online state
           trying to offline 2 out of 96 memory block(s):
online->offline memory0
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh: line 78: echo:
write error: Invalid argument offline_memory_expect_success 0: unexpected
fail
online->offline memory10
online->offline memory11


I guess this test will almost always fail nowadays.

Offline some memory node maybe failed as expected, but the error message is a bit annoying.

Ah, I see it now. We try offlining two and fail offlining the first one. Can we silence that warning in that case somehow?

--
Thanks,

David / dhildenb




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux