RE: [PATCH 4/5] selftests/resctrl: Kill the child process before exiting the parent process if an exception occurs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Reinette,

> On 9/13/2022 6:51 PM, Shaopeng Tan wrote:
> 
> ...
> 
> > @@ -218,11 +219,11 @@ int cat_perf_miss_val(int cpu_no, int n, char
> *cache_type)
> >  			}
> >  		}
> >  		close(pipefd[0]);
> > -		kill(bm_pid, SIGKILL);
> >  	}
> >
> > -	if (bm_pid)
> > -		umount_resctrlfs();
> > +out:
> > +	kill(bm_pid, SIGKILL);
> > +	umount_resctrlfs();
> >
> 
> From what I can tell both parent and child will now run this code. So both will
> attempt to unmount resctrl fs and the child will attempt to kill PID 0?

Thanks for your advice. There are problems as you point out.
I think it is complicated if we fix this bug like MBM/MBA/CMT test using sigaction().
It seems this bug cannot be solved easily.
Please give me some time.

Best Regards,
Shaopeng




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux