On Mon, 2022-09-12 at 07:15 -0700, Sathyanarayanan Kuppuswamy wrote: > > On 9/12/22 12:04 AM, Huang, Kai wrote: > > > + > > > +TDX Guest driver > > > +================ > > > + > > > +The TDX guest driver exposes IOCTL interfaces via /dev/tdx-guest misc > > > +device to allow user space to get certain TDX guest specific details > > > +(like attestation report, attestation quote or storage keys, etc). > > Only TDX_CMD_GET_REPORT is supported now. Whether GetQuote TDVMCALL should be > > supported, or how should it be supported is unknown now. Not to mention "get > > the storage keys". > > The reason for adding them is to give an idea that this driver in future could > be used for use cases other than GetReport. Query about possible use cases came up > in a previous review about /dev/tdx-guest device name usage. So I thought it is > better to give a clear idea on how this device may be used in the future. But I don't think "attestation quote or storage keys" are good example, as it's uncertain, i.e. can be wrong to put here. > > Maybe I can add a note that currently only attestation report is supported. Maybe something like this? " The TDX guest exposes /dev/tdx-guest to userspace to support all TDX guest specific operations in one driver. Currently only TDX_CMD_GET_RERPORT IOCTL is supported to return the TDREPORT to userspace to support attestation for the TDX guest. " -- Thanks, -Kai
