Re: [PATCH] selftests: tpm2: Implement class desstructor to close file descriptor

R Nageswara Sastry <rnsastry@xxxxxxxxxxxxx> · Fri, 9 Sep 2022 21:09:28 +0530

On 09/09/22 8:50 pm, Stefan Berger wrote:
From: Stefan Berger <stefanb@xxxxxxxxxxxxx>

Implement a class destructor to close the open TPM file descriptor
and avoid the following error message:

  test_flush_context (tpm2_tests.SpaceTest) ... \
    /usr/lib64/python3.6/unittest/case.py:605: ResourceWarning: \
    unclosed file <_io.FileIO name='/dev/tpmrm0' mode='rb+' closefd=True>

Fixes: 6ea3dfe1e0732 ("selftests: add TPM 2.0 tests")
Cc: Shuah Khan <shuah@xxxxxxxxxx>
Cc: linux-kselftest@xxxxxxxxxxxxxxx
Cc: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxxxxx>

Tested-by: Nageswara R Sastry <rnsastry@xxxxxxxxxxxxx>


---
  tools/testing/selftests/tpm2/tpm2.py | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/tpm2/tpm2.py b/tools/testing/selftests/tpm2/tpm2.py
index 057a4f49c79d..c7363c6764fc 100644
--- a/tools/testing/selftests/tpm2/tpm2.py
+++ b/tools/testing/selftests/tpm2/tpm2.py
@@ -371,6 +371,10 @@ class Client:
              fcntl.fcntl(self.tpm, fcntl.F_SETFL, flags)
              self.tpm_poll = select.poll()
  
+    def __del__(self):
+        if self.tpm:
+            self.tpm.close()
+
      def close(self):
          self.tpm.close()
  

--
Thanks and Regards
R.Nageswara Sastry






