Re: [PATCH v2] checkpatch: Handle FILE pointer type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2022-09-02 at 13:19 +0200, Mickaël Salaün wrote:
> When using a "FILE *" type, checkpatch considers this an error:
>   ERROR: need consistent spacing around '*' (ctx:WxV)
>   #32: FILE: f.c:8:
>   +static void a(FILE *const b)
[]
> Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>

Acked-by: Joe Perches <joe@xxxxxxxxxxx>

> Link: https://lore.kernel.org/r/20220902111923.1488671-1-mic@xxxxxxxxxxx
> ---
> Changes since v1:
> https://lore.kernel.org/r/20220901145948.1456353-1-mic@xxxxxxxxxxx
> * Remove the FIXTURE_{DATA,VARIANT}() comments.
> * Improve commit description.
> ---
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -576,10 +576,14 @@ our $typeKernelTypedefs = qr{(?x:
>  	(?:__)?(?:u|s|be|le)(?:8|16|32|64)|
>  	atomic_t
>  )};
> +our $typeStdioTypedefs = qr{(?x:
> +	FILE
> +)};
>  our $typeTypedefs = qr{(?x:
>  	$typeC99Typedefs\b|
>  	$typeOtherOSTypedefs\b|
> -	$typeKernelTypedefs\b
> +	$typeKernelTypedefs\b|
> +	$typeStdioTypedefs\b
>  )};
>  
>  our $zero_initializer = qr{(?:(?:0[xX])?0+$Int_type?|NULL|false)\b};
> 
> base-commit: b90cb1053190353cc30f0fef0ef1f378ccc063c5




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux