On Tue, Jul 26, 2022 at 1:07 PM Stephen Boyd <sboyd@xxxxxxxxxx> wrote: > > The other option of using function redirection on the io read() > > write() functions exists, and would be a bit simpler in the > > short-term, but would probably result in a lot of tests reimplementing > > this, and also would have some performance impacts, as the I/O > > accesses wouldn't be able to be inlined if KUNIT is enabled. > > > > That sounds OK to me because nobody is enabling KUNIT in production, > right? You'd think so, but... Android GKI [1] is enabling it. I had thought as =m, but maybe it was =y. I can't find a good link for it now, but e.g. here's a patch they're carrying to prevent KUnit from running built-in tests [2] They could just carry another patch if we go down this route, but it goes to show that there might be others out there w/ reasons to do this. [1] https://source.android.com/devices/architecture/kernel/generic-kernel-image [2] https://android.googlesource.com/kernel/common-patches/+/refs/heads/master/android-mainline/ANDROID-GKI-Disable-KUnit-built-in-testing.patch
