On Tue, 12 Jul 2022 09:29 +0100 Guillaume Tucker wrote: > Add headers as a dependency to kselftest targets so that they can be > run directly from the top of the tree. The kselftest Makefile used to > try to call headers_install "backwards" but failed due to the relative > path not being consistent. > > Now we can either run this directly: > > $ make O=build kselftest-all > > or this: > > $ make O=build headers > $ make O=build -C tools/testing/selftests all > > The same commands work as well when building directly in the source > tree (no O=) or any arbitrary path (relative or absolute). > > Signed-off-by: Guillaume Tucker <guillaume.tucker@xxxxxxxxxxxxx> > --- You might want to add the 'Reported-by: as you did in https://lore.kernel.org/linux-kbuild/a7af58feaa6ae6d3b0c8c55972a470cec62341e5.1657693952.git.guillaume.tucker@xxxxxxxxxxxxx/ ? Tested-by: Nicolas Schier <nicolas@xxxxxxxxx> > > Notes: > v2: replace headers_install with headers > > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 1a6678d817bd..02502cc4ced5 100644 > --- a/Makefile > +++ b/Makefile > @@ -1347,10 +1347,10 @@ tools/%: FORCE > # Kernel selftest > > PHONY += kselftest > -kselftest: > +kselftest: headers > $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests run_tests > > -kselftest-%: FORCE > +kselftest-%: headers FORCE > $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests $* > > PHONY += kselftest-merge > -- > 2.30.2 -- epost|xmpp: nicolas@xxxxxxxxx irc://oftc.net/nsc ↳ gpg: 18ed 52db e34f 860e e9fb c82b 7d97 0932 55a0 ce7f -- frykten for herren er opphav til kunnskap --