On Tue, Jul 12, 2022 at 2:56 AM David Gow <davidgow@xxxxxxxxxx> wrote: > > It's possible that memory allocation for the copy will fail, but for the > copy of the suite to succeed. In this case, the copy could be leaked. > > Properly free 'copy' in the error case for the allocation of 'filtered' > failing. > > Note that there may also have been a similar issue in > kunit_filter_subsuites, before it was removed in "kunit: flatten > kunit_suite*** to kunit_suite** in .kunit_test_suites". > > This was reported by clang-analyzer via the kernel test robot, here: > https://lore.kernel.org/all/c8073b8e-7b9e-0830-4177-87c12f16349c@xxxxxxxxx/ > > Fixes: a02353f49162 ("kunit: bail out of test filtering logic quicker if OOM") > Reported-by: kernel test robot <yujie.liu@xxxxxxxxx> > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> Reviewed-by: Daniel Latypov <dlatypov@xxxxxxxxxx> Thanks for taking care of this.
