On Mon, May 16, 2022 at 3:48 PM 'Daniel Latypov' via KUnit Development <kunit-dev@xxxxxxxxxxxxxxxx> wrote: > > Our main function currently has an optional `linux` argument which is > used to by our unit tests to inject a mock. > We currently have the same code copy-pasted several times to do > if not linux: > linux = MakeRealInstance(cli_args.foo, cli_args.bar, ...) > > But in python, dependency injection isn't necessary or idiomatic when we > can just use mock.patch() to mock things out. > > This change > 1. adds a helper to create a LinuxSourceTree from the cli_args > 2. drops the `linux` parameter in favor of mocking the __init__ func. > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
