On Wed, Jun 29, 2022 at 07:19:36PM +0200, Greg Kroah-Hartman wrote:
> I would be totally and completly amazed if there are any Android kernels
> in real devices in the world that are not at the very least, based on
> LTS releases. But maybe there is, this patch series isn't going to land
> until 5.20, and by then, I think the "define behavior, not hardware" fix
> for random and wg will be properly resolved :)
Properly resolved by whom? It sounds like you're up for intentionally
allowing a userspace regression, and also volunteering other people's
time into fixing that regression? The way I understand the kernel
development process is that the person proposing a change is responsible
for not intentionally causing regressions, and if one is pointed out, a
v+1 of that patch is provided that doesn't cause the regression.
>
> > > In the meantime, this might actually fix issues in desktop distros that
> > > were enabling this option, thinking it only affected the building of a
> > > driver
> >
> > That sounds like a false dichotomy. It's not about "fix Android" vs "fix
> > distros". What I'm suggesting is fixing Android AND fixing distros, by
> > looking at the problem holistically. Trading a bad problem on Android
> > (wg connections are broken) for a manageable problem on distros (something
> > something theoretical warm boot attack something) doesn't sound like a
> > nice trade off. Let's instead get this all fixed at the same time.
>
> Agreed, so what should we use instead in the wg code? What userspace
> functionality are you trying to trigger off of here in the current
> CONFIG_ANDROID check?
It's systems that go to sleep all the time, nonstop, like Android
handsets do. I'm fine with a compile time constant for this, or some
runtime sysctl, or whatever else. It doesn't really matter to me. The
only concern is that the Android people are okay with it and enable it
(and that the distros don't enable it, I guess). So whatever they want
is fine. Or maybe such a runtime indicator already exists. I'm not
sure. But I think a v+1 of this patchset needs to work that out in one
direction or another.
To put it simply,
- I highly suspect that this patch will cause a regression.
- I don't have a ready-made solution offhand to fix said regression.
- The submitter of the patch, now aware of regression potential,
should look into not causing that regression.
That seems pretty clear cut: you're welcome to improve it, but please
don't *intentionally* break my code.
Jason
