From: SeongJae Park <sj@xxxxxxxxxx>
Hi Shuah,
On Mon, 27 Jun 2022 11:00:18 -0600 Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
[...]
> >> --- a/tools/testing/selftests/damon/_chk_dependency.sh
> >> +++ b/tools/testing/selftests/damon/_chk_dependency.sh
> >> @@ -26,3 +26,13 @@ do
> >> exit 1
> >> fi
> >> done
> >> +
> >> +permission_error="Operation not permitted"
> >> +for f in attrs target_ids monitor_on
> >> +do
> >> + status=$( cat "$DBGFS/$f" 2>&1 )
> >> + if [ "${status#*$permission_error}" != "$status" ]; then
> >> + echo "Permission for reading $DBGFS/$f denied; maybe secureboot enabled?"
>
> btw - does this run as a regular user or does it need root privilege?
> If so add a test for that and skip with a message.
It needs the root permission, and does the check at the beginning[1].
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/damon/_chk_dependency.sh?h=v5.19-rc4#n9
Thanks,
SJ
> >> + exit $ksft_skip
> >> + fi
> >> +done
> >> --
> >> 2.36.1
> >
> thanks,
> -- Shuah
