On Thu, 2022-06-16 at 14:47 +0200, Ard Biesheuvel wrote: > Commit b433a52aa28733e0 ("selftests/kexec: update get_secureboot_mode") > refactored the code that discovers the EFI secure boot mode so it only > depends on either the efivars pseudo filesystem or the efivars sysfs > interface, but never both. > > However, the latter version was not implemented correctly, given the > fact that the local 'efi_vars' variable never assumes a value. This > means the fallback has been dead code ever since it was introduced. > > So let's drop the fallback altogether. The sysfs interface has been > deprecated for ~10 years now, and is only enabled on x86 to begin with, > so it is time to get rid of it entirely. > > Cc: Shuah Khan <shuah@xxxxxxxxxx> > Cc: Mimi Zohar <zohar@xxxxxxxxxxxxx> > Signed-off-by: Ard Biesheuvel <ardb@xxxxxxxxxx> Thanks, Ard. Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>