On 6/9/22 4:16 PM, Shuah Khan wrote: > On 6/3/22 8:32 AM, Marcos Paulo de Souza wrote: >> Hi there, >> >> The first patch moves the current livepatch tests to selftests, >> allowing it >> be better suited to contain more complex tests, like using userspace C >> code >> to use the livepatched kernel code. As a bonus it allows to use >> "gen_tar" to export the livepatch selftests, rebuild the modules by >> running make in selftests/livepatch directory and simplifies the process >> of creating and debugging new selftests. >> > > In general selftests don't include modules. We keep test modules under lib. > One of the reasons is that modules have dependencies on the kernel and > should > be built when kernel is built. > > I don't fully buy the argument that moving modules under selftest would > simplify > the process. > Hi Shuah, I see that there is tools/testing/selftests/bpf/bpf_testmod/ which claims to be a "conceptually out-of-tree module". Would similarly moving livepatch test modules under tools/ give us flexibility to write them build for multiple kernel versions? Then one could theoretically build and run the latest, greatest selftests against older kernels (assuming the associate script/module/kernel supports the idea)? Regards, -- Joe
