Re: [PATCH] testing: kselftest_harness: add filtering and enumerating tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/9/22 3:36 PM, Jakub Kicinski wrote:
On Thu, 9 Jun 2022 14:59:18 -0600 Shuah Khan wrote:
Change this to use getopt() to simplify argument parsing and make
it easier to maintain.

Sure thing! Do the options themselves make sense? I wasn't sure if
there are some restrictions or standards since the output is TAP
compatible, AFAIU. Or maybe someone has better ideas.


As for options - please see below:

   Usage: ./tools/testing/selftests/net/tls [-h|-l] [-t|-T|-v|-V|-f|-F|-r name]
    -h       print help
    -l       list all tests

    -t name  include test
    -T name  exclude test

Can be simplified to not include test name by default - drop -T

    -v name  include variant
    -V name  exclude variant

Same here - drop -V

    -f name  include fixture
    -F name  exclude fixture

Same here - drop -F
    -r name  run specified test


Other choices look fine to me.

thanks,
-- Shuah



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux