Hi Hans, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Hans-Schultz/Extend-locked-port-feature-with-FDB-locked-flag-MAC-Auth-MAB/20220524-232455 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 677fb7525331375ba2f90f4bc94a80b9b6e697a3 config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220525/202205250511.beuDDi9L-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 10c9ecce9f6096e18222a331c5e7d085bd813f75) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/5c2d731ec7670b3eb06906c64d66c6098c588a6a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Hans-Schultz/Extend-locked-port-feature-with-FDB-locked-flag-MAC-Auth-MAB/20220524-232455 git checkout 5c2d731ec7670b3eb06906c64d66c6098c588a6a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/dsa/mv88e6xxx/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/net/dsa/mv88e6xxx/chip.c:2754:6: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (!locked_found) { ^~~~~~~~~~~~~ drivers/net/dsa/mv88e6xxx/chip.c:2759:9: note: uninitialized use occurs here return err; ^~~ drivers/net/dsa/mv88e6xxx/chip.c:2754:2: note: remove the 'if' if its condition is always true if (!locked_found) { ^~~~~~~~~~~~~~~~~~~ drivers/net/dsa/mv88e6xxx/chip.c:2749:9: note: initialize the variable 'err' to silence this warning int err; ^ = 0 1 warning generated. vim +2754 drivers/net/dsa/mv88e6xxx/chip.c 2742 2743 static int mv88e6xxx_port_fdb_del(struct dsa_switch *ds, int port, 2744 const unsigned char *addr, u16 vid, 2745 struct dsa_db db) 2746 { 2747 struct mv88e6xxx_chip *chip = ds->priv; 2748 bool locked_found = false; 2749 int err; 2750 2751 if (mv88e6xxx_port_is_locked(chip, port, true)) 2752 locked_found = mv88e6xxx_atu_locked_entry_find_purge(ds, port, addr, vid); 2753 > 2754 if (!locked_found) { 2755 mv88e6xxx_reg_lock(chip); 2756 err = mv88e6xxx_port_db_load_purge(chip, port, addr, vid, 0); 2757 mv88e6xxx_reg_unlock(chip); 2758 } 2759 return err; 2760 } 2761 -- 0-DAY CI Kernel Test Service https://01.org/lkp
