On Tue, May 17, 2022 at 12:45:17PM -0700, Jakub Kicinski wrote: > Yes, we don't have the auto-reply. There's too much noise in some of > the tests, but mostly it's because we don't want to encourage people > posting patches just to build them. If it's a machine replying rather > than a human some may think that it's okay. We already have > jaw-droppingly expensive VM instance to keep up with the build volume. > And the list is very busy. So we can't afford "post to run the CI" > development model. OK, I just afraid the developer doesn't check patchwork status. > > +files=$(git show --name-status --oneline | grep -P '^A\ttools/testing/selftests/net/' | grep '\.sh$' | sed 's@A\ttools/testing/selftests/net/@@') > > +for file in $files; do > > + if echo $file | grep forwarding; then > > + file=$(echo $file | sed 's/forwarding\///') > > + if ! grep -P "[\t| ]$file" tools/testing/selftests/net/forwarding/Makefile;then > > + echo "new test $file not in selftests/net/forwarding/Makefile" >&$DESC_FD > > + rc=1 > > + fi > > + else > > + if ! grep -P "[\t| ]$file" tools/testing/selftests/net/Makefile;then > > + echo "new test $file not in selftests/net/Makefile" >&$DESC_FD > > + rc=1 > > + fi > > Does it matter which exact selftest makefile the changes are? I only checked the tools/testing/selftests/net/Makefile and tools/testing/selftests/net/forwarding/Makefile at present. Maybe mptcp should also added? > Maybe as a first stab we should just check if there are changes > to anything in tools/testing/selftests/.*/Makefile? In my checking only shell scripts are checked, as most net net/forwarding tests using shell script for testing. But other sub-component may use c binary or python for testing. So I think there is no need to check all tools/testing/selftests/.*/Makefile. WDYT? Thanks Hangbin
