On Fri, May 13, 2022 at 4:32 AM David Gow <davidgow@xxxxxxxxxx> wrote: > > Most in-kernel tests (such as KUnit tests) are not supposed to run on > production systems: they may do deliberately illegal things to trigger > errors, and have security implications (for example, KUnit assertions > will often deliberately leak kernel addresses). > > Add a new taint type, TAINT_TEST to signal that a test has been run. > This will be printed as 'N' (originally for kuNit, as every other > sensible letter was taken.) > > This should discourage people from running these tests on production > systems, and to make it easier to tell if tests have been run > accidentally (by loading the wrong configuration, etc.) > > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> Aside from Luis' comment (which I agree with), this looks good. I am not an expert on the taint mechanism, but this seems pretty straightforward. Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
