Re: [RFC V2 PATCH 8/8] selftests: kvm: priv_memfd: Add test avoiding double allocation

To: Vishal Annapurve <vannapurve@xxxxxxxxxx>, x86@xxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
Subject: Re: [RFC V2 PATCH 8/8] selftests: kvm: priv_memfd: Add test avoiding double allocation
From: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 12 May 2022 11:52:41 -0600
Cc: pbonzini@xxxxxxxxxx, vkuznets@xxxxxxxxxx, wanpengli@xxxxxxxxxxx, jmattson@xxxxxxxxxx, joro@xxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, bp@xxxxxxxxx, dave.hansen@xxxxxxxxxxxxxxx, hpa@xxxxxxxxx, shauh@xxxxxxxxxx, yang.zhong@xxxxxxxxx, drjones@xxxxxxxxxx, ricarkol@xxxxxxxxxx, aaronlewis@xxxxxxxxxx, wei.w.wang@xxxxxxxxx, kirill.shutemov@xxxxxxxxxxxxxxx, corbet@xxxxxxx, hughd@xxxxxxxxxx, jlayton@xxxxxxxxxx, bfields@xxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx, yu.c.zhang@xxxxxxxxxxxxxxx, jun.nakajima@xxxxxxxxx, dave.hansen@xxxxxxxxx, michael.roth@xxxxxxx, qperret@xxxxxxxxxx, steven.price@xxxxxxx, ak@xxxxxxxxxxxxxxx, david@xxxxxxxxxx, luto@xxxxxxxxxx, vbabka@xxxxxxx, marcorr@xxxxxxxxxx, erdemaktas@xxxxxxxxxx, pgonda@xxxxxxxxxx, nikunj@xxxxxxx, seanjc@xxxxxxxxxx, diviness@xxxxxxxxxx, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <20220511000811.384766-9-vannapurve@google.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/10/22 6:08 PM, Vishal Annapurve wrote:

Add a memory conversion test without leading to double allocation
of memory backing gpa ranges.


Rather cryptic. Please add more details on why this test is needed
and what it does.

Signed-off-by: Vishal Annapurve <vannapurve@xxxxxxxxxx>
---


Please see comments about coding style related comments on other
patches in this series.

thanks,
-- Shuah

References:
- [RFC V2 PATCH 0/8] selftests: KVM: selftests for fd-based approach of supporting private memory
  - From: Vishal Annapurve
- [RFC V2 PATCH 8/8] selftests: kvm: priv_memfd: Add test avoiding double allocation
  - From: Vishal Annapurve