On Fri, Apr 29, 2022 at 4:56 PM Carlos Llamas <cmllamas@xxxxxxxxxx> wrote: > > Make sure we log relevant information about failed transactions such as > the target proc/thread, call type and transaction id. These details are > particularly important when debugging userspace issues. > > Signed-off-by: Carlos Llamas <cmllamas@xxxxxxxxxx> Acked-by: Todd Kjos <tkjos@xxxxxxxxxx> > --- > drivers/android/binder.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/android/binder.c b/drivers/android/binder.c > index 8351c5638880..f0885baa53a1 100644 > --- a/drivers/android/binder.c > +++ b/drivers/android/binder.c > @@ -3459,8 +3459,12 @@ static void binder_transaction(struct binder_proc *proc, > } > > binder_debug(BINDER_DEBUG_FAILED_TRANSACTION, > - "%d:%d transaction failed %d/%d, size %lld-%lld line %d\n", > - proc->pid, thread->pid, return_error, return_error_param, > + "%d:%d transaction %s to %d:%d failed %d/%d/%d, size %lld-%lld line %d\n", > + proc->pid, thread->pid, reply ? "reply" : > + (tr->flags & TF_ONE_WAY ? "async" : "call"), > + target_proc ? target_proc->pid : 0, > + target_thread ? target_thread->pid : 0, > + t_debug_id, return_error, return_error_param, > (u64)tr->data_size, (u64)tr->offsets_size, > return_error_line); > > -- > 2.36.0.464.gb9c8b46e94-goog >
