On Tue, Apr 12, 2022 at 7:05 PM Mickaël Salaün <mic@xxxxxxxxxxx> wrote: > > I'm wondering about the ASSERT_* and EXPECT_* macros from > tools/testing/selftests/kselftest_harness.h > Do you think we should treat them as "for macros" as well? They can > either be used with or without a following code block. I would keep the style that we have in the kernel -- as far as I can see, that means without a space. Also, from a quick grep, it seems most callers do not use the optional handler, which also makes sense w.r.t. not using a space. Cheers, Miguel