> On 09-Apr-2022, at 12:00 AM, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: > > On 4/8/22 1:24 AM, Athira Rajeev wrote: >> The selftest "mqueue/mq_perf_tests.c" use CPU_ALLOC to allocate >> CPU set. This cpu set is used further in pthread_attr_setaffinity_np >> and by pthread_create in the code. But in current code, allocated >> cpu set is not freed. >> Fix this issue by adding CPU_FREE in the "shutdown" function which >> is called in most of the error/exit path for the cleanup. There are >> few error paths which exit without using shutdown. Add a common goto >> error path with CPU_FREE for these cases. >> Fixes: 7820b0715b6f ("tools/selftests: add mq_perf_tests") >> Signed-off-by: Athira Rajeev <atrajeev@xxxxxxxxxxxxxxxxxx> >> --- >> Changelog: >> From v2 -> v3: >> Addressed review comment from Shuah Khan to add >> common "goto" error path with CPU_FREE for few exit >> cases. >> From v1 -> v2: >> Addressed review comment from Shuah Khan to add >> CPU_FREE in other exit paths where it is needed > > Thank you. I will queue this up for Linux 5.18-rc3 Thanks Shuah Athira > > thanks, > -- Shuah