Re: [PATCH bpf-next] selftests: bpf: use MIN for TCP CC tests

[Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>]

On 4/6/22 10:19 PM, Geliang Tang wrote:
> Use macro MIN() in sys/param.h for TCP CC tests, instead of defining a
> new one.
>
> Signed-off-by: Geliang Tang <geliang.tang@xxxxxxxx>
> ---
>   tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c b/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
> index 8f7a1cef7d87..ceed369361fc 100644
> --- a/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
> +++ b/tools/testing/selftests/bpf/prog_tests/bpf_tcp_ca.c
> @@ -3,6 +3,7 @@
>   
>   #include <linux/err.h>
>   #include <netinet/tcp.h>
> +#include <sys/param.h>
>   #include <test_progs.h>
>   #include "network_helpers.h"
>   #include "bpf_dctcp.skel.h"
> @@ -10,8 +11,6 @@
>   #include "bpf_tcp_nogpl.skel.h"
>   #include "bpf_dctcp_release.skel.h"
>   
> -#define min(a, b) ((a) < (b) ? (a) : (b))
> -

Thank you for cleaning this up. Sanity compile test passed.

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah