On Sat, Mar 26, 2022 at 8:34 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > Recent changes have made it so the current set is not sufficient. > Namely, CONFIG_DEBUG_INFO is not being set even when explicitly asked. > > Specifying a version of the debug info fixes this. > Pick CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT as an option that's > hopefully less fragile (esp. given we're tied to GCC 6 and lower). > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > --- Looks good to me. One idea below, but it's a bit subjective and I'm fine with this going in as-is if you prefer. Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Cheers, -- Daivd > Documentation/dev-tools/kunit/running_tips.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/dev-tools/kunit/running_tips.rst b/Documentation/dev-tools/kunit/running_tips.rst > index 7b6d26a25959..c36f6760087d 100644 > --- a/Documentation/dev-tools/kunit/running_tips.rst > +++ b/Documentation/dev-tools/kunit/running_tips.rst > @@ -114,6 +114,7 @@ Instead of enabling ``CONFIG_GCOV_KERNEL=y``, we can set these options: > > CONFIG_DEBUG_KERNEL=y > CONFIG_DEBUG_INFO=y > + CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y > CONFIG_GCOV=y > > > @@ -122,7 +123,7 @@ Putting it together into a copy-pastable sequence of commands: > .. code-block:: bash > > # Append coverage options to the current config > - $ echo -e "CONFIG_DEBUG_KERNEL=y\nCONFIG_DEBUG_INFO=y\nCONFIG_GCOV=y" >> .kunit/.kunitconfig > + $ echo -e "CONFIG_DEBUG_KERNEL=y\nCONFIG_DEBUG_INFO=y\nCONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y\nCONFIG_GCOV=y" >> .kunit/.kunitconfig > $ ./tools/testing/kunit/kunit.py run Would we want to instead use a chain of --kconfig_add arguments? (I think there are advantages either way...) > # Extract the coverage information from the build dir (.kunit/) > $ lcov -t "my_kunit_tests" -o coverage.info -c -d .kunit/ > > base-commit: b14ffae378aa1db993e62b01392e70d1e585fb23 > -- > 2.35.1.1021.g381101b075-goog >
