On 2/10/22 9:22 PM, Song Bao Hua (Barry Song) wrote:
-----Original Message-----
From: tiantao (H)
Sent: Friday, February 11, 2022 4:15 PM
To: Song Bao Hua (Barry Song) <song.bao.hua@xxxxxxxxxxxxx>; shuah@xxxxxxxxxx;
chenxiang (M) <chenxiang66@xxxxxxxxxxxxx>
Cc: iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx;
linuxarm@xxxxxxxxxxxxx
Subject: [PATCH] dma-mapping: benchmark: Extract a common header file for
map_benchmark definition
kernel/dma/map_benchmark.c and selftests/dma/dma_map_benchmark.c
have duplicate map_benchmark definitions, which tends to lead to
inconsistent changes to map_benchmark on both sides, extract a
common header file to avoid this problem.
Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
+To: Christoph
Looks like a right cleanup. This will help decrease the maintain
overhead in the future. Other similar selftests tools are also
doing this.
Acked-by: Barry Song <song.bao.hua@xxxxxxxxxxxxx>
+1 on this cleanup making this code maintainable. We are moving in
the direction of cleaning up defines in selftests for the same
reason.
Let's just make sure this works on older kernels. We do support
mainline kselftest on stable releases. With that:
Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
thanks,
-- Shuah
