Hi, On Fri, Feb 11, 2022 at 10:41:30AM +0100, Ricardo Ribalda wrote: > Replace the NULL checks with the more specific and idiomatic NULL macros. > > Acked-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx> > --- ... > @@ -2496,50 +2496,50 @@ static void tb_test_property_parse(struct kunit *test) > struct tb_property *p; > > dir = tb_property_parse_dir(root_directory, ARRAY_SIZE(root_directory)); > - KUNIT_ASSERT_TRUE(test, dir != NULL); > + KUNIT_ASSERT_NOT_NULL(test, dir); > > p = tb_property_find(dir, "foo", TB_PROPERTY_TYPE_TEXT); > - KUNIT_ASSERT_TRUE(test, !p); > + KUNIT_ASSERT_NOT_NULL(test, p); This should be KUNIT_ASSERT_NULL(test, p) as we specifically want to check that the property does not exist (!p is same as p == NULL). > p = tb_property_find(dir, "vendorid", TB_PROPERTY_TYPE_TEXT); > - KUNIT_ASSERT_TRUE(test, p != NULL); > + KUNIT_ASSERT_NOT_NULL(test, p); > KUNIT_EXPECT_STREQ(test, p->value.text, "Apple Inc."); > > p = tb_property_find(dir, "vendorid", TB_PROPERTY_TYPE_VALUE); > - KUNIT_ASSERT_TRUE(test, p != NULL); > + KUNIT_ASSERT_NOT_NULL(test, p); > KUNIT_EXPECT_EQ(test, p->value.immediate, 0xa27); > > p = tb_property_find(dir, "deviceid", TB_PROPERTY_TYPE_TEXT); > - KUNIT_ASSERT_TRUE(test, p != NULL); > + KUNIT_ASSERT_NOT_NULL(test, p); > KUNIT_EXPECT_STREQ(test, p->value.text, "Macintosh"); > > p = tb_property_find(dir, "deviceid", TB_PROPERTY_TYPE_VALUE); > - KUNIT_ASSERT_TRUE(test, p != NULL); > + KUNIT_ASSERT_NOT_NULL(test, p); > KUNIT_EXPECT_EQ(test, p->value.immediate, 0xa); > > p = tb_property_find(dir, "missing", TB_PROPERTY_TYPE_DIRECTORY); > - KUNIT_ASSERT_TRUE(test, !p); > + KUNIT_ASSERT_NOT_NULL(test, p); Ditto here. With those fixed (please also run the tests if possible to see that they still pass) you can add, Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thanks!
