On 2/10/22 7:08 AM, Guillaume Nault wrote: > The ->rtm_tos option is normally used to route packets based on both > the destination address and the DS field. However it's ignored for > IPv6 routes. Setting ->rtm_tos for IPv6 is thus invalid as the route > is going to work only on the destination address anyway, so it won't > behave as specified. > > Suggested-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > Signed-off-by: Guillaume Nault <gnault@xxxxxxxxxx> > --- > The same problem exists for ->rtm_scope. I'm working only on ->rtm_tos > here because IPv4 recently started to validate this option too (as part > of the DSCP/ECN clarification effort). > I'll give this patch some soak time, then send another one for > rejecting ->rtm_scope in IPv6 routes if nobody complains. > > net/ipv6/route.c | 6 ++++++ > tools/testing/selftests/net/fib_tests.sh | 13 +++++++++++++ > 2 files changed, 19 insertions(+) > Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>
