On Sat, Feb 5, 2022 at 9:09 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Sat, Feb 05, 2022 at 02:15:37PM +0800, David Gow wrote: > > list_is_head() was added recently[1], and didn't have a KUnit test. The > > implementation is trivial, so it's not a particularly exciting test, but > > it'd be nice to get back to full coverage of the list functions. > > > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/linux/list.h?id=0425473037db40d9e322631f2d4dc6ef51f97e88 > > ... > > > +static void list_test_list_is_head(struct kunit *test) > > +{ > > + struct list_head a, b; > > + > > + KUNIT_EXPECT_TRUE(test, list_is_head(&a, &a)); > > OK. > > > + KUNIT_EXPECT_FALSE(test, list_is_head(&a, &b)); > > Perhaps OK, but the main case here is to test an (arbitrary) member of the existing list. > That makes sense. I've updated the test to verify both the case where the elements are from the same list and where it's from a different list: https://lore.kernel.org/linux-kselftest/20220208040122.695258-2-davidgow@xxxxxxxxxx/T/#u (I've also updated patch 3 for list_entry_is_head() similarly, which was even worse before.) > > +} > Cheers, -- David
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
