On February 2, 2022 1:17:25 PM PST, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: >On 2/2/22 1:11 PM, Sherry Yang wrote: >> seccomp_bpf failed on tests 47 global.user_notification_filter_empty >> and 48 global.user_notification_filter_empty_threaded when it's >> tested on updated kernel but with old kernel headers. Because old >> kernel headers don't have definition of macro __NR_clone3 which is >> required for these two tests. Since under selftests/, we can install >> headers once for all tests (the default INSTALL_HDR_PATH is >> usr/include), fix it by adding usr/include to the list of directories >> to be searched. Use "-isystem" to indicate it's a system directory as >> the real kernel headers directories are. >> >> Signed-off-by: Sherry Yang <sherry.yang@xxxxxxxxxx> >> Tested-by: Sherry Yang <sherry.yang@xxxxxxxxxx> >> --- >> tools/testing/selftests/seccomp/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/seccomp/Makefile b/tools/testing/selftests/seccomp/Makefile >> index 0ebfe8b0e147..585f7a0c10cb 100644 >> --- a/tools/testing/selftests/seccomp/Makefile >> +++ b/tools/testing/selftests/seccomp/Makefile >> @@ -1,5 +1,5 @@ >> # SPDX-License-Identifier: GPL-2.0 >> -CFLAGS += -Wl,-no-as-needed -Wall >> +CFLAGS += -Wl,-no-as-needed -Wall -isystem ../../../../usr/include/ This didn't look right to me. That's outside the build tree, yes? I thought missing headers had been globally solved already for the selftests? Going looking, though, I think I'm thinking of the KBUILD_OUTPIT work. Hm. I thought there was a proper "updated kernel headers" dependency that should be used for this? -Kees >> LDFLAGS += -lpthread >> >> TEST_GEN_PROGS := seccomp_bpf seccomp_benchmark >> > >Looks good to me. Adding Kees Cook for his review of this change. > >thanks, >-- Shuah -- Kees Cook
