On 2/2/22 11:30 AM, Guillaume Nault wrote:
Although both iproute2 and the kernel accept 1 and 2 as tos values for new routes, those are invalid. These values only set ECN bits, which are ignored during IPv4 fib lookups. Therefore, no packet can actually match such routes. This selftest therefore only succeeds because it doesn't verify that the new routes do actually work in practice (it just checks if the routes are offloaded or not). It makes more sense to use tos values that don't conflict with ECN. This way, the selftest won't be affected if we later decide to warn or even reject invalid tos configurations for new routes.
Wouldn't it make sense to leave these invalid values in the test though. Removing these makes this test out of sync withe kernel. thanks, -- Shuah
