On Tue, Jan 25, 2022 at 4:00 PM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > The concern is that having a lot of redundant fields in kunit_assert can > blow up stack usage if the compiler doesn't optimize them away [1]. > > The comment on this field implies that it was meant to be initialized > when the expect/assert was declared, but this only happens when we run > kunit_do_failed_assertion(). > > We don't need to access it outside of that function, so move it out of > the struct and make it a local variable there. > > This change also takes the chance to reduce the number of macros by > inlining the now simplified KUNIT_INIT_ASSERT_STRUCT() macro. > > [1] https://groups.google.com/g/kunit-dev/c/i3fZXgvBrfA/m/VULQg1z6BAAJ > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
