On Wed, Jan 26, 2022 at 2:55 PM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > On Thu, Jan 20, 2022 at 9:19 AM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > > That being said, I can live with the current solution, but'd ideally > > > like a comment or something to make the return value Tuple a bit more > > > obvious. > > > > A comment to explain that Tuple == multiple return values from a func? > > Or something else? > > Friendly ping. > Do we want a comment like this? > > # Note: Python uses tuples internally for multiple return values > def foo() -> Tuple[int, int] > return 0, 1 I don't feel that's necessary. I think the use of tuple return types in Python is fairly common and don't require a comment, but I don't feel strongly about it either way. > I can go ahead and add that and send a v2 out. > > FYI, if you do this in a REPL > >>> a = foo() > >>> type(a) > <class 'tuple'> > > The syntax for `a, b = foo()` is just using Python's unpacking feature, i.e. > b, c = (1, 2) > > So it's all just syntactic sugar around tuples. > > > > > Also ah, I thought we had more instances of multiple return in kunit.py. > > Looks like the only other is get_source_tree_ops_from_qemu_config(). > > isolate_ktap_output() technically shows this off as well, but via yields. > > > > > > > > Thoughts? Personally, I think the change as is.
