on 2022/1/26 4:33, Shuah Khan wrote : > On 12/15/21 2:56 AM, Yang Xu wrote: >> Since kernel commit 43209ea2d17a ("zram: remove max_comp_streams >> internals"), zram has >> switched to per-cpu streams. Even kernel still keep this interface for >> some reasons, but >> writing to max_comp_stream doesn't take any effect. So remove it. > > I get that max_comp_stream doesn't do anything since this referenced > commit. Don't we need this test on older kernels since older kernels > still support max_comp_stream? I read the following info from kernel selftest documentation https://www.kernel.org/doc/html/latest/dev-tools/kselftest.html "The kernel contains a set of “self tests” under the tools/testing/selftests/ directory. These are intended to be small tests to exercise individual code paths in the kernel. Tests are intended to be run after building, installing and booting a kernel." So, we can build older kernel(use older kernel source) if we want to test older kernel. IMO, kerenl selftest is different from other testsuit(ie ltp, this shuould think about api changes because ltp may test on different kernel). Also cc ltp co-maintainer Petr Or, did I miss something? Best Regards Yang Xu > > thanks, > -- Shuah