Hi Reinette, > On 1/20/2022 11:59 PM, tan.shaopeng@xxxxxxxxxxx wrote: > > Hi Reinette, > > > >> On 12/13/2021 2:01 AM, Shaopeng Tan wrote: > >>> This commit changed the default limited time(45s) to 120 seconds for > >> > >> (This commit) > >> > >>> resctrl_tests by adding "setting" file. Since 45 seconds may not be > >>> enough on some machine environments. > >> > >> This sounds very imprecise when you say "may not be enough". From > >> what I understand you have already encountered systems where this is > >> not enough so you have established that 45 seconds is too short. The > >> next question is, how was 120 seconds determined and how do you know it > will be enough? > > > > It took about 68 seconds in my environment (Intel(R) Xeon(R) Gold 6254 CPU > @ 3.10GHz). > > This test accesses a fixed size(250M) memory by default settings which > > is used when run in kselftest framework. > > I think that the execution time does not change significantly in different > environments. > > So, I roughly doubled the execution time and get 120s, which I set to the > limited time. > > I think it is enough for any environments. > > If 120s are also not enough, user can freely set the limited time by "setting" > file. > > > > How about something like: > > When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl > selftests fail > due to timeout after exceeding the default time limit of 45 seconds. On this > system > the test takes about 68 seconds. Since the failing test by default accesses a > fixed > size of memory the execution time should not vary significantly between > different > environment. A new default of 120 seconds should be sufficient yet easy to > customize > with the introduction of the "settings" file for reference. Thanks for your feedback. I will use it for commit log in next version. Best regards, Tan Shaopeng
