On Mon, Jan 10, 2022 at 2:14 PM Brendan Higgins <brendanhiggins@xxxxxxxxxx> wrote: > > On Fri, Jan 7, 2022 at 8:23 PM Daniel Latypov <dlatypov@xxxxxxxxxx> wrote: > > > > Currently, these macros are only really documented near the bottom of > > https://www.kernel.org/doc/html/latest/dev-tools/kunit/api/test.html#c.KUNIT_FAIL. > > > > E.g. it's likely someone might just not realize that > > KUNIT_EXPECT_STREQ() exists and instead use KUNIT_EXPECT_FALSE(strcmp()) > > or similar. > > > > This can also serve as a basic smoketest that the KUnit assert machinery > > still works for all the macros. > > > > Signed-off-by: Daniel Latypov <dlatypov@xxxxxxxxxx> > > I still don't like how much this bloats the example test; aside from > that, this looks good. Agreed, it does add bloat. I just wanted something *somewhere* I could use to smoketest the later changes. I just remembered how people weren't very aware of the _MSG variants and thought this could help. If others have a preference, I'll happily move out and into kunit-test.c. I'm fine either way as I initially was going to put it there to begin with. > > Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>
