Hello: This patch was applied to netdev/net.git (master) by David S. Miller <davem@xxxxxxxxxxxxx>: On Fri, 10 Dec 2021 15:25:23 +0800 you wrote: > If any sub-test in this icmp_redirect.sh is failing but not expected > to fail. The script will complain: > ./icmp_redirect.sh: line 72: [: 1: unary operator expected > > This is because when the sub-test is not expected to fail, we won't > pass any value for the xfail local variable in log_test() and thus > it's empty. Fix this by passing 0 as the 4th variable to log_test() > for non-xfail cases. > > [...] Here is the summary with links: - [PATCHv2] selftests: icmp_redirect: pass xfail=0 to log_test() https://git.kernel.org/netdev/net/c/3748939bce3f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html