On Wed, Dec 8, 2021 at 6:02 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > On Tue, Dec 07, 2021 at 11:02:51AM -0800, David Gow wrote: > > From: Rae Moar <rmoar@xxxxxxxxxx> > > > > It does not make any significant additions or changes other than those > > already in use in the kernel: additional features can be added as they > > become necessary and used. > > > > [1]: https://testanything.org/tap-version-13-specification.html > > > > Signed-off-by: Rae Moar <rmoar@xxxxxxxxxx> > > Co-developed-by: David Gow <davidgow@xxxxxxxxxx> > > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> > > I like it! Thank you so much for suffering through my earlier reviews. > :) > > The only concern I have is wonder what'll be needed to kselftest to > deal with indentation changes. As long as this can be implemented > without a subtest knowing it is a subtest, we're good. I'd think a minor tweak to the prefix.pl script should handle it for most tests: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/tree/tools/testing/selftests/kselftest/prefix.pl Certainly the indent should be the only difference between a top-level test result and a subtest now. And, if the results do use test plans (i.e., state how many tests are expected beforehand) it's possible to parse the results even without indentation. It it looks like it would be a problem, we could explicitly state that indentation is optional if a test plan is present (or provide some other mechanism for detecting the end of the subtests: just checking the test number has some corner cases which'd fail, but doing something akin to the "Subtest:" header TAP14 used makes this pretty robust). Things like that would overcomplicate it a bit, though, and might end up verging back on "tests need to know they're subtests" territory, depending on the exact implementation, so I think things are probably better as-is. Cheers, -- David
