Sabrina Dubroca <sd@xxxxxxxxxxxxxxx> wrote:
> Hello Maciej,
>
> 2021-11-10, 12:44:44 +0100, Maciej Machnikowski wrote:
> > diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> > index 5888492a5257..1d8662afd6bd 100644
> > --- a/include/uapi/linux/rtnetlink.h
> > +++ b/include/uapi/linux/rtnetlink.h
> > @@ -185,6 +185,9 @@ enum {
> > RTM_GETNEXTHOPBUCKET,
> > #define RTM_GETNEXTHOPBUCKET RTM_GETNEXTHOPBUCKET
> >
> > + RTM_GETEECSTATE = 124,
> > +#define RTM_GETEECSTATE RTM_GETEECSTATE
>
> I'm not sure about this. All the other RTM_GETxxx are such that
> RTM_GETxxx % 4 == 2. Following the current pattern, 124 should be
> reserved for RTM_NEWxxx, and RTM_GETEECSTATE would be 126.
More importantly, why is this added to rtnetlink (routing sockets)?
It appears to be unrelated?
Looks like this should be in ethtool (it has netlink api nowadays) or
devlink.
