On Tue, Nov 02, 2021 at 11:09:43AM -0400, Willem de Bruijn wrote: > On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@xxxxxxxxx> wrote: > > > > When generating the selftests to another folder, the toeplitz.sh > > and toeplitz_client.sh are missing as they are not in Makefile, e.g. > > > > make -C tools/testing/selftests/ install \ > > TARGETS="net" INSTALL_PATH=/tmp/kselftests > > > > Making them under TEST_PROGS_EXTENDED as they test NIC hardware features > > and are not intended to be run from kselftests. > > > > Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test") > > Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx> > > Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx> Thanks for the review. > > The same might apply to the icmp and vrf tests? I am not familiar with those. icmp and vrf are running for selftests. They should be added to TEST_PROGS. Thanks Hangbin