Re: [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 02, 2021 at 11:09:43AM -0400, Willem de Bruijn wrote:
> On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@xxxxxxxxx> wrote:
> >
> > When generating the selftests to another folder, the toeplitz.sh
> > and toeplitz_client.sh are missing as they are not in Makefile, e.g.
> >
> >   make -C tools/testing/selftests/ install \
> >       TARGETS="net" INSTALL_PATH=/tmp/kselftests
> >
> > Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
> > and are not intended to be run from kselftests.
> >
> > Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> > Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
> 
> Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx>

Thanks for the review.
> 
> The same might apply to the icmp and vrf tests? I am not familiar with those.

icmp and vrf are running for selftests. They should be added to TEST_PROGS.

Thanks
Hangbin



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux